Catch exceptions when changing the audio communication device#6226
Open
jmartinesp wants to merge 1 commit intodevelopfrom
Open
Catch exceptions when changing the audio communication device#6226jmartinesp wants to merge 1 commit intodevelopfrom
jmartinesp wants to merge 1 commit intodevelopfrom
Conversation
…ce in Element Call
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6226 +/- ##
===========================================
- Coverage 81.42% 81.41% -0.01%
===========================================
Files 2570 2570
Lines 69778 69784 +6
Branches 8950 8952 +2
===========================================
Hits 56817 56817
- Misses 9640 9646 +6
Partials 3321 3321 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Content
Catch exceptions when changing the audio communication device in Element Call, log the errors instead.
Motivation and context
Fix https://sentry.tools.element.io/organizations/element/issues/11227938/events/894944cf6c414234972e7ff766d22a70/
Tests
I don't think this one can be easily tested.
Checklist