Disable the cross-process lock in the SDK#6231
Conversation
We don't use multiple process as iOS does, so we don't need it. It should improve DB performance a bit and overall waste less resources.
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6231 +/- ##
===========================================
- Coverage 81.42% 81.42% -0.01%
===========================================
Files 2570 2570
Lines 69788 69789 +1
Branches 8950 8950
===========================================
Hits 56825 56825
- Misses 9643 9644 +1
Partials 3320 3320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| override fun provide(): ClientBuilder { | ||
| return ClientBuilder() | ||
| // Make sure all built clients use the single process cross-process lock config | ||
| .crossProcessLockConfig(CrossProcessLockConfig.SingleProcess) |
There was a problem hiding this comment.
RustClientBuilderProvider is a way to hide the usage of org.matrix.rustcomponents.sdk.ClientBuilder.
I'd move the configuration in RustMatrixClientFactory.getBaseClientBuilder instead.
2 participants
Content
What the title says.
Motivation and context
We don't use multiple process as iOS does, so we don't need it. It should improve DB performance a bit and overall waste less resources.
Tests
Use the app normally, check you can receive push notifications and they get processed as usual. Battery usage should decrease too, but that's a bit more difficult to measure.
Tested devices
Checklist