Skip to content

Add extra analytics for notification performance#6237

Merged
jmartinesp merged 3 commits intodevelopfrom
misc/add-analytics-for-notification-performance
Feb 24, 2026
Merged

Add extra analytics for notification performance#6237
jmartinesp merged 3 commits intodevelopfrom
misc/add-analytics-for-notification-performance

Conversation

@jmartinesp
Copy link
Member

Content

Add technical spans to track how long a notification fetching work request takes to run, then how long it takes to actually fetch the events for the notifications.

An example of one of this transactions is here.

Motivation and context

Try to understand what can make notification fetching slow.

Tests

Not much to test, other than running the branch with analytics enabled and looking at Sentry after a while.

Tested devices

  • Physical
  • Emulator
  • OS version(s): 16

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

Add technical spans to track how long a notification fetching work request takes to run, then how long it takes to actually fetch the events for the notifications
@jmartinesp jmartinesp added the PR-Misc For other changes label Feb 23, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2026

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/sdmftY

The default `Dispatchers.Default` dispatcher used should be good enough and more performant
@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 78.84615% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.42%. Comparing base (efb2098) to head (3f6b161).
⚠️ Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
.../push/impl/workmanager/FetchNotificationsWorker.kt 67.64% 4 Missing and 7 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6237      +/-   ##
===========================================
- Coverage    81.42%   81.42%   -0.01%     
===========================================
  Files         2570     2570              
  Lines        69788    69833      +45     
  Branches      8950     8961      +11     
===========================================
+ Hits         56825    56860      +35     
- Misses        9643     9646       +3     
- Partials      3320     3327       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmartinesp jmartinesp force-pushed the misc/add-analytics-for-notification-performance branch from 9fed2bc to 3f6b161 Compare February 23, 2026 14:28
@sonarqubecloud
Copy link

@jmartinesp jmartinesp marked this pull request as ready for review February 24, 2026 07:48
@jmartinesp jmartinesp requested a review from a team as a code owner February 24, 2026 07:48
@jmartinesp jmartinesp requested review from ganfra and removed request for a team February 24, 2026 07:48
@jmartinesp jmartinesp merged commit ce3df76 into develop Feb 24, 2026
31 of 32 checks passed
@jmartinesp jmartinesp deleted the misc/add-analytics-for-notification-performance branch February 24, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants