Ensure that Element X can use the service from Element Classic.

[bmarty]

Content

Ensure that Element X can use the service from Element Classic.
Permission "im.vector.app.READ_DATA" is not necessary anymore, but the manifest must contain a package tag in the queries block.

Also iterate on the expected received secrets.

The flow is not fully working yet, this is an intermediate PR.

Motivation and context

Part of #6143

Screenshots / GIFs

NA

Tests

No expected change if the flag to sign in with Element Classic is disabled (which is the default behavior).

Tested devices

• Physical
• Emulator
• OS version(s):

Checklist

• Changes have been tested on an Android device or Android emulator with API 24
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request title will be used in the release note, it clearly define what will change for the user
• Pull request includes screenshots or videos if containing UI changes
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/r3SdDs

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ElementBot]

	Warnings
⚠️	features/login/impl/src/main/kotlin/io/element/android/features/login/impl/screens/onboarding/classic/ElementClassicConnection.kt#L165 - This Handler class should be static or leaks might occur (io.element.android.features.login.impl.screens.onboarding.classic.DefaultElementClassicConnection.IncomingHandler)

Generated by 🚫 dangerJS against 1e8bbed

[jmartinesp]

LGTM, but it seems like there are some failing CI flows.

[codecov]

Codecov Report

❌ Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.43%. Comparing base (efb2098) to head (1e8bbed).
⚠️ Report is 22 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ens/onboarding/classic/ElementClassicConnection.kt	27.27%	8 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #6238   +/-   ##
========================================
  Coverage    81.42%   81.43%           
========================================
  Files         2570     2570           
  Lines        69788    69785    -3     
  Branches      8950     8951    +1     
========================================
+ Hits         56825    56827    +2     
+ Misses        9643     9638    -5     
  Partials      3320     3320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.