Draft
Conversation
Collaborator
5f5ea80 to
7be76a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
When recovering from Recovery, use the new
recoverAndFixBackupmethod that fixes key storage if the public and private keys are out of sync.(Depends on matrix-org/matrix-rust-sdk#6252)
Motivation and context
For element-hq/element-meta#3059 we want to detect when the key storage keys are inconsistent, and automatically fix the problem by creating a new backup. This change does that using the functionality recently added to matrix-rust-sdk.
Screenshots / GIFs
Nothing changes visually, except after the "Key Storage Out Of Sync" banner appears and we choose "Enter Recovery Key" and enter it, the banner disappears. Previously, if backup keys were out of sync, it would remain.
Tests
No tests were changed.
Tested devices
Checklist