Skip to content

Design iteration on file attachment in the timeline#6322

Open
bmarty wants to merge 3 commits intodevelopfrom
feature/bma/iterateDesignOnAttachment
Open

Design iteration on file attachment in the timeline#6322
bmarty wants to merge 3 commits intodevelopfrom
feature/bma/iterateDesignOnAttachment

Conversation

@bmarty
Copy link
Member

@bmarty bmarty commented Mar 11, 2026

Content

Design iteration on file attachment in the timeline

Motivation and context

Closes #6319

Screenshots / GIFs

See recorded screenshot

Tests

  • Open a timeline with file attachment
  • See the new design

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty requested a review from a team as a code owner March 11, 2026 15:05
@bmarty bmarty requested review from jmartinesp and removed request for a team March 11, 2026 15:05
@bmarty bmarty added the PR-Misc For other changes label Mar 11, 2026
@bmarty
Copy link
Member Author

bmarty commented Mar 11, 2026

@americanrefugee can you check the recorded screenshots here: 9a67da5? Thanks!

@jmartinesp
Copy link
Member

jmartinesp commented Mar 11, 2026

Just checking, the issue says 'For any files, always/only use the Attachment icon, and do not differentiate between a known file type (e.g. PDF) or unknown/unrecognized file type.', shouldn't that mean we should also use this for TimelineItemAudioView? Or even replace it with the generic TimelineItemFileView?

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/iM5ZgA

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.26%. Comparing base (98df854) to head (9a67da5).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ine/components/event/ElementTimelineItemPreview.kt 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6322      +/-   ##
===========================================
- Coverage    81.26%   81.26%   -0.01%     
===========================================
  Files         2578     2579       +1     
  Lines        70234    70239       +5     
  Branches      9022     9023       +1     
===========================================
+ Hits         57076    57080       +4     
  Misses        9800     9800              
- Partials      3358     3359       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Misc For other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Timeline bubbles > Update icon and frame for File

3 participants