Maestro (local): queue pending runs in the maestro-test concurrency group instead of cancelling them - #7656
Open
andreBurnt wants to merge 1 commit into
Open
Conversation
…roup With the default (queue: single), a run that finishes Build APK while another run is already pending in the maestro-test group cancels that pending run, which then never gets a Maestro verdict for its commit. queue: max keeps the one-at-a-time constraint (no cancel-in-progress) and lets up to 100 runs wait, at no runner cost. Fixes element-hq#7654 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Add
queue: maxto themaestro-testconcurrency group on theMaestro test suitejob. One-at-a-time execution is unchanged (nocancel-in-progress); the only difference is that runs waiting for the slot now queue instead of the newest one cancelling the one already pending.Motivation and context
Fixes #7654. With the default (
queue: single), when run A is executing and run B is pending, run C finishingBuild APKcancels B within a second; B's PR then has no Maestro verdict for that commit and nothing re-runs it. Two timestamped instances are in the issue. GitHub's docs for the property: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/control-the-concurrency-of-workflows-and-jobs (up to 100 pending runs, no runner cost while pending;queue: maxis explicitly incompatible withcancel-in-progress: true, which this group does not use).Screenshots / GIFs
n/a (CI only)
Tests
actionlint1.7.12 reportsunexpected key "queue" for "concurrency" section: its schema predates the property. GitHub's workflow validator accepts it (see the docs above); the PR's own workflow run is the check.cancelledwith 0 steps will instead wait and then execute.Tested devices
Checklist
Independent of #7653's PR; both touch adjacent lines of the same file, so whichever lands second I will rebase. Label:
PR-Misc(cannot add from a fork).