Skip to content

Add a developer option for history sharing on invite#4172

Merged
stefanceriu merged 1 commit intodevelopfrom
rav/history_sharing_labs
Jun 11, 2025
Merged

Add a developer option for history sharing on invite#4172
stefanceriu merged 1 commit intodevelopfrom
rav/history_sharing_labs

Conversation

@richvdh
Copy link
Copy Markdown
Member

@richvdh richvdh commented Jun 5, 2025

Adds a new developer flag, enabling our experimental support for MSC4268.

Part of element-hq/element-meta#2871. Requires matrix-org/matrix-rust-sdk#5141, so won't build yet. An equivalent to element-hq/element-x-android#4821.

@richvdh richvdh added the pr-feature for a new feature label Jun 5, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 5, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against f19196f

@richvdh richvdh force-pushed the rav/history_sharing_labs branch from 21c34fe to 8985cdc Compare June 5, 2025 12:59
@richvdh
Copy link
Copy Markdown
Member Author

richvdh commented Jun 5, 2025

This is draft for now pending a release of matrix-sdk including matrix-org/matrix-rust-sdk#5141, but:

Please note I lack Apple hardware, so this is completely untested. I figured this would give someone who knows what they are doing a place to start.

@stefanceriu
Copy link
Copy Markdown
Member

This looks great, thank you @richvdh!
Presumably we can go ahead and merge this as soon as a new SDK version is available, right?

@richvdh
Copy link
Copy Markdown
Member Author

richvdh commented Jun 6, 2025

Yup, hope so!

Adds a new developer flag, enabling our experimental support for MSC4268.
@stefanceriu stefanceriu force-pushed the rav/history_sharing_labs branch from 8985cdc to f19196f Compare June 11, 2025 06:42
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 79.15%. Comparing base (db3f9f4) to head (f19196f).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...perOptionsScreen/View/DeveloperOptionsScreen.swift 0.00% 10 Missing ⚠️
...s/Authentication/AuthenticationClientBuilder.swift 0.00% 2 Missing ⚠️
...ources/Services/UserSession/UserSessionStore.swift 0.00% 2 Missing ⚠️
...mentX/Sources/Other/Extensions/ClientBuilder.swift 0.00% 1 Missing ⚠️
NSE/Sources/NSEUserSession.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4172      +/-   ##
===========================================
+ Coverage    79.13%   79.15%   +0.01%     
===========================================
  Files          820      820              
  Lines        75051    75065      +14     
===========================================
+ Hits         59393    59417      +24     
+ Misses       15658    15648      -10     
Flag Coverage Δ
unittests 71.27% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu marked this pull request as ready for review June 11, 2025 08:23
@stefanceriu stefanceriu requested a review from a team as a code owner June 11, 2025 08:23
@stefanceriu stefanceriu requested review from stefanceriu and removed request for a team June 11, 2025 08:23
@stefanceriu stefanceriu merged commit 394eb00 into develop Jun 11, 2025
13 checks passed
@stefanceriu stefanceriu deleted the rav/history_sharing_labs branch June 11, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature for a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants