Fix call service completion handler calls. #5026
Merged
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanceriu
force-pushed
the
stefan/callServiceCallbacks
branch
from
a500813 to
06c03cc
Compare
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
stefanceriu
force-pushed
the
stefan/callServiceCallbacks
branch
from
06c03cc to
b357121
Compare
Member
I've just checked twice on my side. Using this PR I get no call ringing. Reverting back to 26.02.0 and calls are able to ring again. |
This reverts commit b357121.
…ing incoming pushes Fixes `Killing app because it never posted an incoming call to the system after receiving a PushKit VoIP push` crashes Initially tried replacing the callback based API with the async one but notifications stopped coming in. See associated PR for commits and details.
pixlwave
approved these changes
Feb 2, 2026
Member
pixlwave
left a comment
pixlwave
left a comment
There was a problem hiding this comment.
LGTM. Might also be worthwhile to keep the async version under a different name and call that from the working delegate method in a withCheckedContinuation but not super important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid
Killing app because it never posted an incoming call to the system after receiving a PushKit VoIP pusherrors.Making this a draft as I can't tell if the async version of the API is broken or there's something else that prevents it from workign on my dev environment.