Skip to content

Update Send button bg color#5170

Open
americanrefugee wants to merge 2 commits intodevelopfrom
Aaron/send-button
Open

Update Send button bg color#5170
americanrefugee wants to merge 2 commits intodevelopfrom
Aaron/send-button

Conversation

@americanrefugee
Copy link
Contributor

Change the gradient bg to accent/rest.

We talked about killing the accent button generally, but the Send button currently has a gradient bg - which looks out of place with the rest of the app. @amshakal do you agree with this?

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@americanrefugee americanrefugee requested a review from a team as a code owner March 6, 2026 11:28
@americanrefugee americanrefugee requested review from pixlwave and removed request for a team March 6, 2026 11:28
@pixlwave pixlwave added pr-change for updates to an existing feature labels Mar 6, 2026
@amshakal
Copy link
Member

It's not wrong. It does look out of place.

@pixlwave
Copy link
Member

Noting that this is blocked for now as the send button should also be styled with Liquid Glass on iOS 26

americanrefugee and others added 2 commits March 20, 2026 14:55
Change the gradient bg to accent/rest.
Also simplifies the tests a bit.
@pixlwave pixlwave force-pushed the Aaron/send-button branch from 25bfce6 to 605d4ae Compare March 20, 2026 21:58
@codecov
Copy link

codecov bot commented Mar 20, 2026

Codecov Report

❌ Patch coverage is 93.47826% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.67%. Comparing base (81a5e3c) to head (605d4ae).
⚠️ Report is 3 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...mScreen/ComposerToolbar/View/ComposerToolbar.swift 89.18% 4 Missing ⚠️
...ineItemViews/HighlightedTimelineItemModifier.swift 0.00% 1 Missing ⚠️
...X/Sources/Screens/Timeline/View/TimelineView.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5170   +/-   ##
========================================
  Coverage    74.67%   74.67%           
========================================
  Files          787      787           
  Lines        52559    52545   -14     
========================================
- Hits         39246    39240    -6     
+ Misses       13313    13305    -8     
Flag Coverage Δ
unittests 64.59% <93.47%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-change for updates to an existing feature X-Blocked

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants