Conversation
a4c466e to
64052ee
Compare
51d8d0a to
b962fc4
Compare
1cb295d to
16553ba
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #5209 +/- ##
===========================================
+ Coverage 74.66% 74.72% +0.05%
===========================================
Files 787 790 +3
Lines 52558 52865 +307
===========================================
+ Hits 39244 39503 +259
- Misses 13314 13362 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1c8a07d to
0b778ff
Compare
stefanceriu
left a comment
There was a problem hiding this comment.
It's shaping up quite nicely 👍
| // Live user with avatar | ||
| LocationMarkerView(kind: .liveUser(.mockDan), | ||
| mediaProvider: MediaProviderMock(configuration: .init())) | ||
| .colorScheme(.dark) |
There was a problem hiding this comment.
I wonder if it's worth automating dark scheme preview tests. We do have a lot of screenshots already though..
ElementX/Sources/Screens/LocationSharing/View/LocationSharingScreen.swift
Show resolved
Hide resolved
ElementX/Sources/Services/Timeline/TimelineItemContent/TimelineEventContent.swift
Show resolved
Hide resolved
...tX/Sources/Services/Timeline/TimelineItems/Items/Messages/LiveLocationRoomTimelineItem.swift
Outdated
Show resolved
Hide resolved
...tX/Sources/Services/Timeline/TimelineItems/Items/Messages/LiveLocationRoomTimelineItem.swift
Show resolved
Hide resolved
ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemFactory.swift
Outdated
Show resolved
Hide resolved
|
Oh, one more thing, please update the PR title: |
# Conflicts: # ElementX/Sources/Other/Logging/Tracing.swift # ElementX/Sources/Services/Authentication/AuthenticationService.swift # ElementX/Sources/Services/Authentication/LinkNewDeviceService.swift
88f8fee to
0239707
Compare
| // Live user with avatar | ||
| LocationMarkerView(kind: .liveUser(.mockDan), | ||
| mediaProvider: MediaProviderMock(configuration: .init())) | ||
| .colorScheme(.dark) |
|
|
||
| import SwiftUI | ||
|
|
||
| struct PreviewScrollView<Content: View>: View { |
There was a problem hiding this comment.
Perhaps we should wrap it in a #if DEBUG so it enforces the Only use in Previews?
This PR introduces a new timeline item to handle the Live Location sharing.
As of right now this PR only handles the rendering of such item, but doesn't provide any actions when it is tapped.
This includes:
NOTE: There are some bugs within the SDK that make the item no work properly sometimes like:
isLiveis always falseThese are entirely SDK issues, so they will be fixed in a future update