Skip to content

Rename Sign Out to Remove Device + Update SDK 26.03.18#5280

Merged
Velin92 merged 5 commits intodevelopfrom
mauroromito/update_sdk_26-3-18
Mar 18, 2026
Merged

Rename Sign Out to Remove Device + Update SDK 26.03.18#5280
Velin92 merged 5 commits intodevelopfrom
mauroromito/update_sdk_26-3-18

Conversation

@Velin92
Copy link
Member

@Velin92 Velin92 commented Mar 18, 2026

Also regenerated preview tests

Velin92 added 3 commits March 18, 2026 15:07
# Conflicts:
#	ElementX/Sources/Screens/Timeline/View/Style/TimelineItemSendInfoLabel.swift
#	ElementX/Sources/Screens/Timeline/View/TimelineItemViews/LiveLocationRoomTimelineView.swift
@Velin92 Velin92 requested a review from a team as a code owner March 18, 2026 14:33
@Velin92 Velin92 requested review from pixlwave and removed request for a team March 18, 2026 14:33
@Velin92 Velin92 added the pr-change for updates to an existing feature label Mar 18, 2026
@Velin92 Velin92 changed the title Update SDK 26.03.18 Rename Sign Out to Remove Device + Update SDK 26.03.18 Mar 18, 2026
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 18.51852% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.66%. Comparing base (860a7de) to head (f79bd94).
⚠️ Report is 1 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...lementX/Sources/Other/Extensions/ProcessInfo.swift 0.00% 7 Missing ⚠️
ElementX/Sources/Other/Logging/Tracing.swift 40.00% 3 Missing ⚠️
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 40.00% 3 Missing ⚠️
...meline/TimelineItems/RoomTimelineItemFactory.swift 0.00% 3 Missing ⚠️
...ervices/Authentication/AuthenticationService.swift 0.00% 2 Missing ⚠️
...Services/Authentication/LinkNewDeviceService.swift 0.00% 2 Missing ⚠️
...ices/Room/RoomSummary/RoomEventStringBuilder.swift 33.33% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5280      +/-   ##
===========================================
- Coverage    74.68%   74.66%   -0.03%     
===========================================
  Files          787      787              
  Lines        52538    52552      +14     
===========================================
- Hits         39240    39237       -3     
- Misses       13298    13315      +17     
Flag Coverage Δ
unittests 64.61% <18.51%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all minor comments.

@Velin92 Velin92 merged commit dfee18e into develop Mar 18, 2026
6 checks passed
@Velin92 Velin92 deleted the mauroromito/update_sdk_26-3-18 branch March 18, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-change for updates to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants