Update reply view border corner radii and color#5341
Conversation
And also update relating preview test snapshots
americanrefugee
left a comment
There was a problem hiding this comment.
Why are there double sentences for sharing a location?
That's expected, the tests also run in Double-Length Pseudolanguage to check how layouts work with longer words. |
...s/__Snapshots__/PreviewTests/timelineItemBubbledStylerView.Thread-decorator-iPhone-en-GB.png
Show resolved
Hide resolved
@pixlwave Yes, that's fine to me. There wasn't a lot of contrast between the reply contents and a received message, but there's certainly enough contrast between the reply contents and a sent message. This way the border overall isn't too stark. I personally like this update. Do you agree? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5341 +/- ##
===========================================
- Coverage 74.38% 74.38% -0.01%
===========================================
Files 800 800
Lines 53519 53519
===========================================
- Hits 39812 39811 -1
- Misses 13707 13708 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
left a comment
There was a problem hiding this comment.
Yes, that's fine to me.
In which case, LGTM 👍
And also update relating preview test snapshots