Skip to content

Update reply view border corner radii and color#5341

Merged
stefanceriu merged 1 commit intodevelopfrom
stefan/replyViewBorder
Apr 1, 2026
Merged

Update reply view border corner radii and color#5341
stefanceriu merged 1 commit intodevelopfrom
stefan/replyViewBorder

Conversation

@stefanceriu
Copy link
Copy Markdown
Member

And also update relating preview test snapshots

And also update relating preview test snapshots
@stefanceriu stefanceriu requested a review from a team as a code owner April 1, 2026 14:22
Copy link
Copy Markdown
Contributor

@americanrefugee americanrefugee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there double sentences for sharing a location?

@stefanceriu
Copy link
Copy Markdown
Member Author

Why are there double sentences for sharing a location?

That's expected, the tests also run in Double-Length Pseudolanguage to check how layouts work with longer words.

@americanrefugee
Copy link
Copy Markdown
Contributor

Is it intentional to use the same border colour as the outgoing message bubble background? This basically means that messages have a border around the reply view but outgoing messages don't?

@pixlwave Yes, that's fine to me. There wasn't a lot of contrast between the reply contents and a received message, but there's certainly enough contrast between the reply contents and a sent message.

This way the border overall isn't too stark. I personally like this update. Do you agree?

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.38%. Comparing base (48794a2) to head (c438b7c).
⚠️ Report is 1 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...eens/Timeline/View/Replies/TimelineReplyView.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5341      +/-   ##
===========================================
- Coverage    74.38%   74.38%   -0.01%     
===========================================
  Files          800      800              
  Lines        53519    53519              
===========================================
- Hits         39812    39811       -1     
- Misses       13707    13708       +1     
Flag Coverage Δ
unittests 64.52% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's fine to me.

In which case, LGTM 👍

@stefanceriu stefanceriu added the pr-misc for other changes label Apr 1, 2026
@stefanceriu stefanceriu enabled auto-merge (rebase) April 1, 2026 15:40
@stefanceriu stefanceriu merged commit 2b8c21a into develop Apr 1, 2026
13 of 15 checks passed
@stefanceriu stefanceriu deleted the stefan/replyViewBorder branch April 1, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-misc for other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants