Skip to content

Remove the shouldDisambiguateDisplayNames parameter from the RoomEvent and RoomStateEvent string builders#5344

Merged
stefanceriu merged 1 commit intodevelopfrom
stefan/shouldDisambiguate
Apr 2, 2026
Merged

Remove the shouldDisambiguateDisplayNames parameter from the RoomEvent and RoomStateEvent string builders#5344
stefanceriu merged 1 commit intodevelopfrom
stefan/shouldDisambiguate

Conversation

@stefanceriu
Copy link
Copy Markdown
Member

Doug and I had a think about it and we can't come up with a reason why names should ever not be disambiguated

…vent` and `RoomStateEvent` string builders.
@stefanceriu stefanceriu requested a review from a team as a code owner April 2, 2026 08:34
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team April 2, 2026 08:34
@stefanceriu stefanceriu added the pr-misc for other changes label Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.59%. Comparing base (2b8c21a) to head (bfea367).
⚠️ Report is 1 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ices/Room/RoomSummary/RoomEventStringBuilder.swift 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5344   +/-   ##
========================================
  Coverage    74.59%   74.59%           
========================================
  Files          800      800           
  Lines        53519    53505   -14     
========================================
- Hits         39920    39912    -8     
+ Misses       13599    13593    -6     
Flag Coverage Δ
unittests 64.53% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave
Copy link
Copy Markdown
Member

pixlwave commented Apr 2, 2026

Let's see 🤞

@stefanceriu stefanceriu merged commit 5984001 into develop Apr 2, 2026
13 of 16 checks passed
@stefanceriu stefanceriu deleted the stefan/shouldDisambiguate branch April 2, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-misc for other changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants