Add an action to the newly introduced FloatingDateBadge that scrolls the timeline to that day.#5350
Add an action to the newly introduced FloatingDateBadge that scrolls the timeline to that day.#5350stefanceriu wants to merge 2 commits intodevelopfrom
Conversation
…the timeline to that day.
| .padding(.horizontal, 16) | ||
| .padding(.vertical, 8) | ||
| .background(backgroundColor, in: .capsule) | ||
| .shadow(color: Color(red: 0.11, green: 0.11, blue: 0.13).opacity(0.1), radius: 12, x: 0, y: 4) |
There was a problem hiding this comment.
this needs to be moved outside the button
There was a problem hiding this comment.
Does it make a difference? 🤔
Velin92
left a comment
There was a problem hiding this comment.
LGTM, just address my other small nit comments please 🙏
|
I think this should/could automatically back paginate, so you really are at the beginning of the day, wdyt? |
ElementX/Sources/Screens/Timeline/TimelineTableViewController.swift
Outdated
Show resolved
Hide resolved
I thought about it but it would've complicated this PR significantly and I also don't know whether it would be good UX or not to have this thing randomly scroll in steps. |
This could mean a lot of backpagination however... (in the context of big and spammy rooms) I like the idea a lot but maybe let's start small. I imagine that if we had an API from the SDK that gave at least from the store, the timeline identifier of the matching date separator, we could instead use the focus event API to get there faster, but yeah just an idea. |
|
I know that this is not the same thing, but clicking on the floating date is just a particular case of focusing the timeline at a specific date. |


No description provided.