Clean up how pagination parameters are handled #3272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
10ffb1f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4376680c.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-frontend-pagination.matrix-authentication-service-docs.pages.dev |
sandhose
added
A-Frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up how we handle pagination parameters and validate them.
This means we don't have to put the first page parameters each time we construct a link
It also means links to the initial page are cleaner, and overall we're not in typing hell anymore.