Skip to content

Implement login_hint as per MSC4198 #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 18, 2024
Merged

Implement login_hint as per MSC4198 #3343

merged 8 commits into from
Nov 18, 2024

Conversation

tonkku107
Copy link
Contributor

Implements the most basic case of login_hint handling for MSC4198 where the username field is prepopulated based on the hint value

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

sandhose
sandhose requested changes Nov 18, 2024
View reviewed changes
Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, that looks good! Sorry for the delay on reviewing.

Just one small nit, if you could remove the mas-data-model -> mas-matrix dependency, that would be perfect!

@tonkku107 tonkku107 requested a review from sandhose November 18, 2024 10:24
sandhose
sandhose approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@sandhose sandhose merged commit 00432dd into element-hq:main Nov 18, 2024
18 checks passed
@tonkku107 tonkku107 deleted the login-hint branch November 18, 2024 10:50
@tonkku107 tonkku107 mentioned this pull request Nov 18, 2024
Open
@sandhose sandhose added the T-Enhancement New feature of request label Dec 16, 2024
@sandhose sandhose changed the title Implement login_hint Implement login_hint as per MSC4198 Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandhose sandhose sandhose approved these changes

Assignees

No one assigned

Labels

T-Enhancement New feature of request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tonkku107 @CLAassistant @sandhose