Skip to content

Conversation

ginkel
Copy link
Contributor

@ginkel ginkel commented Oct 21, 2024

This PR adds documentation for setting up MAS with Authelia as OIDC IdP.

@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just a small nitpick but otherwise looks good to me

Add a client for MAS to the Authelia configuration:

```yaml
- client_id: "<client-id>" # TO BE FILLED
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include where this is exactly in the config?
Something like:

identity_providers:
  oidc:
    clients:
      - client_id: "<client-id>" # TO BE FILLED

And maybe with a link to the relevant documentation: https://www.authelia.com/configuration/identity-providers/openid-connect/clients/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks for your feedback!

Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Wrong button, wanted to 'request changes')

Signed-off-by: Thilo-Alexander Ginkel <[email protected]>
@ginkel ginkel force-pushed the feature/sso-authelia-docs branch from 690b681 to b616d0d Compare October 24, 2024 21:24
@ginkel ginkel requested a review from sandhose October 24, 2024 21:26
Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!

@sandhose sandhose merged commit c13c886 into element-hq:main Oct 25, 2024
16 checks passed
@sandhose sandhose added A-Documentation Improvements or additions to documentation T-Enhancement New feature of request labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Documentation Improvements or additions to documentation T-Enhancement New feature of request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants