-
Notifications
You must be signed in to change notification settings - Fork 57
Consume jobs from the new job queue #3455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
Latest commit: |
6d92fb1
|
Status: | ✅ Deploy successful! |
Preview URL: | https://2035bfc0.matrix-authentication-service-docs.pages.dev |
Branch Preview URL: | https://quenting-new-queue-jobs.matrix-authentication-service-docs.pages.dev |
6add451
to
c455959
Compare
28d01c0
to
c3237ce
Compare
c455959
to
74e6eae
Compare
c3237ce
to
36921bd
Compare
0d88685
to
86a6664
Compare
36921bd
to
4cbd066
Compare
86a6664
to
0d5c391
Compare
reivilibre
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally LGTM
SELECT $1, queue_name, payload, metadata, $2, attempt + 1 | ||
FROM queue_jobs | ||
WHERE queue_job_id = $3 | ||
AND status = 'failed' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this also say AND next_attempt_id IS NULL
?
4cbd066
to
0000132
Compare
0d5c391
to
954bd71
Compare
0000132
to
fdc3d9a
Compare
954bd71
to
6d92fb1
Compare
Base automatically changed from
quenting/new-queue/insert-jobs
to
quenting/new-queue/merge
December 6, 2024 08:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #3367
This does the bulk of processing jobs in the queue.
With this PR there are four main things missing from the job queue: