Skip to content

Conversation

sandhose
Copy link
Member

On top of #3455

This adds a way to schedule a job to run at a specific time.
It also tweaks the retry logic to use this new feature and retry with an exponential backoff.

@sandhose sandhose added the A-Jobs Related to asynchronous jobs label Nov 22, 2024
Copy link

cloudflare-workers-and-pages bot commented Nov 22, 2024

Deploying matrix-authentication-service-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7b120f1
Status: ✅  Deploy successful!
Preview URL: https://cac38160.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://quenting-new-queue-scheduled.matrix-authentication-service-docs.pages.dev

View logs

Copy link
Contributor

@reivilibre reivilibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

Comment on lines +534 to +535
1 => tracing::warn!("One scheduled job marked as available"),
n => tracing::warn!("{n} scheduled jobs marked as available"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surprised by warn.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, that's probably a copy-paste failure

@sandhose sandhose force-pushed the quenting/new-queue/jobs branch from 0d5c391 to 954bd71 Compare December 5, 2024 10:14
@sandhose sandhose force-pushed the quenting/new-queue/scheduled-jobs branch from 016ada0 to e0071dd Compare December 5, 2024 10:15
Also retries jobs with an exponential backoff.
@sandhose sandhose force-pushed the quenting/new-queue/scheduled-jobs branch from e0071dd to 7b120f1 Compare December 5, 2024 17:03
@sandhose sandhose force-pushed the quenting/new-queue/jobs branch from 954bd71 to 6d92fb1 Compare December 5, 2024 17:03
Base automatically changed from quenting/new-queue/jobs to quenting/new-queue/merge December 6, 2024 08:39
@sandhose sandhose merged commit 82e3438 into quenting/new-queue/merge Dec 6, 2024
2 checks passed
@sandhose sandhose deleted the quenting/new-queue/scheduled-jobs branch December 6, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Jobs Related to asynchronous jobs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants