Fix non-form_post upstream OAuth 2.0 callbacks
#3554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
091b096
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b1179e0d.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-siwa-fixes.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/siwa-fixes
branch
from
bea458f to
091b096
Compare
reivilibre
approved these changes
Nov 22, 2024
sandhose
added
the
A-Upstream-OAuth
sandhose
added
the
T-Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the
Formextractor will… just use the query parameters for GET requests, which breaks them, as we tried to be smart and check if we had a query string or a form body.Because for GET requests, both
QueryandFormextractors ended up returning something, we shouted about it.Also, I forgot to push my last commit before merging so :(