-
Notifications
You must be signed in to change notification settings - Fork 58
Upstream OAuth 2.0 providers: Support signed userinfo and customising the expected id_token signature algorithm #3664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9626af1 to
55c54d0
Compare
55c54d0 to
7c4f1de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
A few things to fix:
id_token_signed_response_algshouldn't be optional, I haven't seen that specced anywhereuserinfo_signed_response_algshould default toNone, as it's the most common case
crates/storage-pg/migrations/20241202123523_upstream_oauth_responses_alg.sql
Outdated
Show resolved
Hide resolved
c5ca149 to
dbb5d42
Compare
dbb5d42 to
59a5c8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there, just still would like to have the userinfo_signed_response_alg default to Option::None
crates/storage-pg/migrations/20241202123523_upstream_oauth_responses_alg.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
Add options to upstream OAuth config to specify the expected signing algorithm for the endpoint JWT responses.