Polish the password recovery flow and other small design tweaks #3780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
7c57d09
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://546fe133.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-design-review-jan-2.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/design-review-jan-25
branch
2 times, most recently
from
cac9d67 to
20aa7ce
Compare
reivilibre
requested changes
Jan 8, 2025
Comment on lines
+331
to
+336
| /// The input for the `resendRecoveryEmail` mutation. | ||
| #[derive(InputObject)] | ||
| pub struct ResendRecoveryEmailInput { | ||
| /// The recovery ticket to use. | ||
| ticket: String, | ||
| } |
There was a problem hiding this comment.
I don't understand the intended flow for this.
I assumed the recovery ticket is the code that arrives in the e-mail (embedded in a URL, probably) and that lets you recover the account.
So why would you use a recovery ticket to resend the recovery e-mail?
If the ticket is more public than that, I don't think I am happy with the idea that you can use a ticket to request the username of the user...
edit: from the client code I think I gleam that it's for expired tickets. If so, can you state that more clearly in the documentation for the resend operation?
There was a problem hiding this comment.
That's right, I've added a comment in 8a69c9a
reivilibre
approved these changes
Jan 13, 2025
This includes: - show an error message if the recovery link is expired, with a button to resend the email - show an error message if the recovery link has already been used - include an invisible username field in the form, so that password managers can save the new password
sandhose
force-pushed
the
quenting/design-review-jan-25
branch
from
e708212 to
7c57d09
Compare
sandhose
added
A-Local-Password
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3032
This can be reviewed commit by commit: