Skip to content

Remove warnings about password auth not being feature complete #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Remove warnings about password auth not being feature complete #4106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions tools/syn2mas/src/advisor.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,6 @@ export async function advisor(): Promise<void> {
warn(
"Synapse has a non-standard password auth enabled which won't work after migration and will need to be manually mapped to an upstream OpenID Provider during migration",
);
} else if (synapseConfig.password_config?.enabled !== false) {
warn(
"Synapse has password auth enabled, but support for password auth in MAS is not feature complete",
);
}

const externalIdAuthProviders = (await synapse
Expand All @@ -213,8 +209,8 @@ export async function advisor(): Promise<void> {
synapse.count("*").from<SUser>("users").whereNotNull("password_hash"),
);
if (usersWithPassword > 0) {
warn(
`Synapse database contains ${usersWithPassword} users with a password which will be migrated. However, support for password auth in MAS is not feature complete`,
log.info(
`Synapse database contains ${usersWithPassword} users with a password which will be migrated.`,
);
}

Expand Down
Loading