Admin API to dynamically set policy data #4115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
6a37fdf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9de2a56f.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-dynamic-policy-data.matrix-authentication-service-docs.pages.dev |
sandhose
added
A-Admin-API
sandhose
force-pushed
the
quenting/dynamic-policy-data
branch
from
15a4828 to
c8a33f0
Compare
sandhose
added
the
Z-Build-Workflow
github-actions
bot
removed
the
Z-Build-Workflow
Contributor
|
A build for this PR at commit 6eca7b1 has been created through the Z-Build-Workflow label by sandhose. Docker image is available at:
Pre-built binaries are available through the workflow run artifacts. |
sandhose
added
the
Z-Build-Workflow
github-actions
bot
removed
the
Z-Build-Workflow
Contributor
|
A build for this PR at commit 1a87716 has been created through the Z-Build-Workflow label by sandhose. Docker image is available at:
Pre-built binaries are available through the workflow run artifacts. |
reivilibre
requested changes
Mar 4, 2025
Contributor
reivilibre
left a comment
reivilibre
left a comment
There was a problem hiding this comment.
seems good, though not sure about the overkillness of the schema?
reivilibre
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3993
This adds a way to dynamically set the policy data through an admin API call.
This data is then stored in the database, and merged with the policy data from the configuration file.
Note that it merges both objects, concatenates arrays, overridding any values with the ones from the dynamic data.
We keep an history in the database of the policy data, so that when looking at the logs, we can look which 'version' of the policy data was used during policy evaluation.
When setting the policy data through the API, it validates it and will refuse anything that it can't load in the WASM module. It will immediately load it in the current instance; other instances load it regularly (every minute) from the database, so there is maximum a 1 minute lag between the admin API being called and it being effective on all workers.