Ignore guest devices and empty IPs when migrating from Synapse #4121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhose
added
A-Migration
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
b6bb596
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://798348a4.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-syn2mas-ignore-thin.matrix-authentication-service-docs.pages.dev |
reivilibre
requested changes
Mar 3, 2025
| }; | ||
|
|
||
| let Some((localpart, server_name)) = without_sigil.split_once(':') else { | ||
| let Some((localpart, server_name)) = without_sigil.rsplit_once(':') else { |
There was a problem hiding this comment.
This is different from Synapse's splitting logic (see below refs) and moreover would break on @user:localhost:4242...
- https://github.com/element-hq/synapse/blob/154e23f6d76277cc8012dc7a5dfa5f22d62b9133/synapse/server.py#L394
- https://github.com/element-hq/synapse/blob/154e23f6d76277cc8012dc7a5dfa5f22d62b9133/synapse/types/__init__.py#L305
If we have truly broken user IDs in the m.org DB then .... maybe it'd be best to find a way to exorcise the database of those :/
There was a problem hiding this comment.
Alright, I reverted this for now; the problematic user on matrix.org is an AS one, and has no 3pid or device, so I'll do a proper fix to ignore this user once the PR to read AS users lands
This reverts commit 7263bca.
reivilibre
approved these changes
Mar 3, 2025
sandhose
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be reviewed commit by commit
First commit is to handle localparts that have colons in them (for some reason), e.g.@foo:bar:matrix.orgSecond commit is to not warn when importing '-' as IP address, because Synapse will use this value sometimes
Thirds is to ignore devices with the
guest_devicesas device ID, as we don't care about importing those