Allow configuring a 'read-only' connection to the homeserver #4145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help us write other implementations of HomeserverConnection
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
d0f1cf4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://961df87d.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-readonly-homeserver.matrix-authentication-service-docs.pages.dev |
sandhose
added
A-Homeserver-Integration
reivilibre
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a wrapper to
HomeserverConnectionwhich prevents any 'write' operation to be performed on the connection.This is to help rolling out MAS with a simple way to rollback in case of issues.
A better version of this would give feedback on those operations, detect 'read-only' mode and update the UI accordingly. I might do this in another PR.
I also refactored the
HomeserverConnectiontrait to remove the generic error type (because we always usedanyhow::Errorfor now), and also made it so that we always carry anArc<dyn HomeserverConnection>instead of aBox<dyn HomeserverConnection>that is created on the fly