Properly accumulate form errors on the upstream register page #4173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
9668418
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b2e36739.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-upstream-oauth-bett.matrix-authentication-service-docs.pages.dev |
sandhose
added
A-Upstream-OAuth
sandhose
changed the title
reivilibre
approved these changes
Mar 10, 2025
Co-authored-by: reivilibre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes things so that we don't return on the first error during validation, but rather accumulate them and show a proper errored form a the end.
This is mainly to fix #4170, as we weren't evaluating the policy if the homeserver told us the username isn't available.
This is how it looks like if you choose invalid chars in the username after this patch: