-
Notifications
You must be signed in to change notification settings - Fork 54
Allow linking upstream accounts for existing users when the localpart matches in upstream OAuth 2.0 logins #4193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow linking upstream accounts for existing users when the localpart matches in upstream OAuth 2.0 logins #4193
Conversation
9d35eeb
to
d50b6c0
Compare
d50b6c0
to
405abce
Compare
405abce
to
11f17cc
Compare
8f7d65b
to
0307f3c
Compare
0307f3c
to
63f811a
Compare
fa428d9
to
3d64262
Compare
3d64262
to
f5a3404
Compare
e2b0077
to
4405e08
Compare
Wrong configuration of providerWhen activating the option
|
This comment was marked as resolved.
This comment was marked as resolved.
e910c49
to
00d8171
Compare
b877b9c
to
ea8c8d2
Compare
@sandhose I'm done with the required modifications, I think we can consider updating the user flow by skipping the screen in a second step. If good with you, we can merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Almost there, just a few minor stylistic things, but I think this should make the cut for the next RC on Tuesday!
… OAuth 2.0 logins
Co-authored-by: Quentin Gliech <[email protected]>
Co-authored-by: Quentin Gliech <[email protected]>
Co-authored-by: Quentin Gliech <[email protected]>
Co-authored-by: Quentin Gliech <[email protected]>
Co-authored-by: Quentin Gliech <[email protected]>
Co-authored-by: Quentin Gliech <[email protected]>
999dfe9
to
3e9d572
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks! It should be part of the 0.20.0-rc.0 tomorrow 💃
Fixes Point 1 and 4 in #2089
Introducing new configuration
on_conflict
in sectionclaims_imports.localpart
to set the account linking strategyfail
(default value): do nothing, and fail the registration/login (corresponds to allow_existing_users: false in Synapse)add
: import the link without overriding existing links for this user (corresponds to allow_existing_users: true in Synapse)replace
: import the link and replace any existing link for this user => not implemented in this PRset
: import the link if and only if there is no existing link for this user => not implemented in this PRconfirmation page when configuration is

on_conflict: add
: