Speed up local docker rebuilds & CI cache exports #4289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
6903c3d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://407b61ac.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-ci-docker-cache.matrix-authentication-service-docs.pages.dev |
sandhose
added
the
Z-Build-Workflow
sandhose
added
A-CI
|
A build for this PR at commit 692aea6 has been created through the Z-Build-Workflow label by sandhose. Docker image is available at:
Pre-built binaries are available through the workflow run artifacts. |
github-actions
bot
removed
the
Z-Build-Workflow
reivilibre
reviewed
Mar 25, 2025
Comment on lines
+117
to
+118
| --mount=type=cache,target=/root/.cargo/registry \ | ||
| --mount=type=cache,target=/app/target \ |
There was a problem hiding this comment.
I can't easily tell, but should these have id=mas-<unique ID> so that they don't share the same cache with other dockerfiles that have caches in these locations?
(Under podman it seems like they might just hash the target option and use that as the cache key)
There was a problem hiding this comment.
Erf, not sure it really matters honestly? 🤷
We can always change that later
reivilibre
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We almost never cache the Rust build in Docker, because it always changes, because the version injected is always different.
The thing is, we always export the build cache in the CI, which always includes this huge layer, as it includes the
target/directory.This changes so that the
cargo builduses a cache mount, which means that:target/directory, making them (in theory) faster to export. Before: 214s to export cache, after: 27s