Skip to content

Allow logging in using an email address #4337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2025
Merged

Allow logging in using an email address #4337

merged 3 commits into from
Apr 10, 2025

Conversation

mcalinghee
Copy link
Contributor

@mcalinghee mcalinghee commented Apr 3, 2025 •
edited
Loading

  • allow the login by email
    • note that an account can be linked to multiple emails
    • note that an email cannot be used for multiple account
  • introduce login_with_email_allowed configuration if email login is allowed
image

@mcalinghee mcalinghee marked this pull request as ready for review April 3, 2025 11:44
@mcalinghee mcalinghee marked this pull request as draft April 3, 2025 11:46
@mcalinghee mcalinghee force-pushed the feat/login_by_email branch from a0b2c87 to b97bf49 Compare April 3, 2025 11:52
@mcalinghee mcalinghee marked this pull request as ready for review April 3, 2025 11:58
@mcalinghee mcalinghee marked this pull request as draft April 3, 2025 11:59
@mcalinghee mcalinghee force-pushed the feat/login_by_email branch from b97bf49 to 464cebc Compare April 3, 2025 13:51
@mcalinghee mcalinghee marked this pull request as ready for review April 3, 2025 13:55
@mcalinghee mcalinghee force-pushed the feat/login_by_email branch 2 times, most recently from 7571a97 to 4191c45 Compare April 3, 2025 14:51
@mcalinghee mcalinghee changed the title add login by email + feature flag allow login by email Apr 3, 2025
sandhose
sandhose requested changes Apr 8, 2025
View reviewed changes
Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things on the translations, other than that LGTM, thanks a lot!

@mcalinghee mcalinghee force-pushed the feat/login_by_email branch 2 times, most recently from ce594b8 to d6ff9f7 Compare April 10, 2025 15:31
@mcalinghee mcalinghee marked this pull request as draft April 10, 2025 15:34
@mcalinghee mcalinghee force-pushed the feat/login_by_email branch from d6ff9f7 to 8058d42 Compare April 10, 2025 15:49
@mcalinghee mcalinghee force-pushed the feat/login_by_email branch from 8058d42 to 77e954e Compare April 10, 2025 15:58
@mcalinghee mcalinghee marked this pull request as ready for review April 10, 2025 16:00
@mcalinghee mcalinghee requested a review from sandhose April 10, 2025 16:00
sandhose
sandhose approved these changes Apr 10, 2025
View reviewed changes
@sandhose sandhose changed the title allow login by email Allow logging in using an email address Apr 10, 2025
@mcalinghee @sandhose
Update translations/en.json
87f7ba3 
Co-authored-by: Quentin Gliech <[email protected]>
@sandhose sandhose enabled auto-merge April 10, 2025 17:54
@sandhose sandhose merged commit 4a14e36 into element-hq:main Apr 10, 2025
20 checks passed
@sandhose sandhose added A-Login-Flow Related to the user login flow T-Enhancement New feature of request labels Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandhose sandhose sandhose approved these changes

Assignees

No one assigned

Labels

A-Login-Flow Related to the user login flow T-Enhancement New feature of request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mcalinghee @sandhose