Allow requests to the compat login endpoint without a Content-Type header #4369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
7f4e975
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a06531ec.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-compat-no-content-t.matrix-authentication-service-docs.pages.dev |
sandhose
added
A-Compatibility-Layer
reivilibre
approved these changes
Apr 8, 2025
crates/handlers/src/compat/mod.rs
Outdated
Comment on lines
144
to
145
| serde_json::from_slice(&bytes).map_err(MatrixJsonBodyRejection::NotJson)?; | ||
| let value = serde_json::from_value(value).map_err(MatrixJsonBodyRejection::BadJson)?; |
There was a problem hiding this comment.
I guess these requests are tiny so this is fine. But if they were big, I'd rather avoid this and you could use .is_syntax() on the serde_json Error.
There was a problem hiding this comment.
You're right, better do that. I used .is_data() instead
sandhose
added
the
T-Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4340