Always ask for consent, never for reauth #4386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have deduplicated clients, we're in this weird situation where authorization grants just… go through. This is because 4 years ago, I designed it to support prompt=consent and prompt=none, but that never ended up being used/mentioned in the MSCs. We also had support for max_age, but that required reauthing, which doesn't work well with upstream providers. So this removes support for prompt=consent|none and max_age, and makes sure we always go through the consent page. Lots of code deleted, yay!
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
26dcba6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fc0db386.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-always-consent.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/always-consent
branch
from
d3aeafa to
26dcba6
Compare
reivilibre
approved these changes
Apr 14, 2025
sandhose
added
T-Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have deduplicated clients, we're in this weird situation where authorization grants just… go through.
This is because 4 years ago, I designed it to support prompt=consent and prompt=none, but that never ended up being used/mentioned in the MSCs.
We also had support for max_age, but that required reauthing, which doesn't work well with upstream providers.
So this removes support for prompt=consent|none and max_age, and makes sure we always go through the consent page.
We'll remove the tables for consent in the N+1 version so that DB rollback is possible
This greatly simplifies the logic for receiving a auth request. Lots of code deleted, yay!