Avoid deadlocks when flushing session activities #4463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
e2dde82
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fd807a23.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-activity-tracker-de.matrix-authentication-service-docs.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error when flushing session activity when MAS is deployed across multiple processes:
Failed to flush activity tracker: error returned from database: deadlock detectedThis happens because PG will lock rows in the order they appear in the transaction, so if we don't order them predictably, two transactions can deadlock
I've also did a few pass-by fixes, like using
tokio::time::intervalinstead oftokio::time::sleepfor the flush loop.I've also added a gauge to track the number of pending records in the activity tracker, so that we can detect better when it's misbehaving