-
Notifications
You must be signed in to change notification settings - Fork 57
Forward the login_hint
upstream.
#4512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b58344f
c5e0f16
691c055
096ce60
e4a4261
6d29ebb
26d84c5
0d1caae
2d4f24e
e3c7b80
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,9 @@ | ||
# Rust | ||
target/ | ||
|
||
# Editors | ||
.idea | ||
.nova | ||
|
||
# OS garbage | ||
.DS_Store | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -565,4 +565,11 @@ pub struct Provider { | |
/// Orders of the keys are not preserved. | ||
#[serde(default, skip_serializing_if = "BTreeMap::is_empty")] | ||
pub additional_authorization_parameters: BTreeMap<String, String>, | ||
|
||
/// Whether the `login_hint` should be forwarded to the provider in the | ||
/// authorization request. | ||
/// | ||
/// Defaults to `false`. | ||
#[serde(default)] | ||
pub forward_login_hint: bool, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I imagine this should be a template to allow people to configure what exactly gets forwarded based on their upstream provider's requirements There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think later on we'd want a behaviour which looks up the user based on a But for now, this simple feature of just forwarding the login_hint as-is could already be valuable for some deployments |
||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have those in my global git-config, that's why I never bothered :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whaaat, there's a global gitignore?! Why did nobody ever tell me this before?!! 😂😂
Would you like me to revert this or is it useful for anyone who doesn't have (or know about) global ignores?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it's a thing!
I'm fine with keeping it though :)