Skip to content

Fix MSC2966 compliance around redirect_uri validity #4529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 9, 2025
Merged

Fix MSC2966 compliance around redirect_uri validity #4529

merged 4 commits into from
May 9, 2025

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 7, 2025 •
edited
Loading

Fixes #4528

  • Allows URI without trailing slash on empty path
  • Allows URI containing a query segment at end

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented May 7, 2025 •
edited
Loading

Deploying matrix-authentication-service-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ba986d3
Status: ✅  Deploy successful!
Preview URL: https://dce98c37.matrix-authentication-service-docs.pages.dev
Branch Preview URL: https://t3chguy-fix-4528.matrix-authentication-service-docs.pages.dev

View logs

@t3chguy t3chguy self-assigned this May 7, 2025
@t3chguy t3chguy marked this pull request as ready for review May 8, 2025 07:23
@t3chguy t3chguy requested a review from sandhose May 8, 2025 07:32
@sandhose
Copy link
Member

sandhose commented May 8, 2025

Whilst we're at it, could you also allow any port on https urls? It's in the secure_url util

@t3chguy
Copy link
Member Author

t3chguy commented May 8, 2025

@sandhose done

sandhose
sandhose approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyvm!

@sandhose sandhose merged commit 7309d1e into main May 9, 2025
20 checks passed
@sandhose sandhose deleted the t3chguy/fix/4528 branch May 9, 2025 07:22
@sandhose sandhose mentioned this pull request May 9, 2025
Closed
@sandhose sandhose added T-Defect Something isn't working A-Spec-Compliance Divergence from the Matrix or the OAuth 2.0/OIDC specifications labels Jun 10, 2025
@renovate renovate bot mentioned this pull request Jul 15, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandhose sandhose sandhose approved these changes

Assignees

@t3chguy t3chguy

Labels

A-Spec-Compliance Divergence from the Matrix or the OAuth 2.0/OIDC specifications T-Defect Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MAS fails to support query params in redirect_uri - incompliant with MSC2966

2 participants

@t3chguy @sandhose