-
Notifications
You must be signed in to change notification settings - Fork 55
Support for experimental plan management tab in UI #4549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 20 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
457ade5
WIP support for experimental plan management tab in UI
hughns 70838ef
Fixes
hughns a173370
Format
hughns 0f82979
Set the iframe height based on content height
hughns 074f8ff
No need for the action as can link direct to /account/plan
hughns 96f1b59
Revert "No need for the action as can link direct to /account/plan"
hughns 0caf325
Default height value
hughns b79cc6f
Merge remote-tracking branch 'refs/remotes/origin/hughns/plan-managem…
hughns 25de9bc
Merge branch 'main' into hughns/plan-management
hughns c6a3fc5
Lint
hughns 5a71d49
Lint
hughns 26af568
Tidy up
hughns 45ab34f
Redirect to / if no URI configured
hughns be01f11
Merge remote-tracking branch 'refs/remotes/origin/hughns/plan-managem…
hughns 2e90b23
Use <Navigate> component insert of redirect()
hughns 8ef1277
Do fallback redirect at router level
hughns d4882b0
Review feedback
hughns 34defa7
Handle unloading
hughns ce7bd5f
Get mutation observer working
hughns 58aa499
Iterate
hughns b49a477
Update frontend/src/routes/_account.plan.index.tsx
hughns 18d30b3
Lint
hughns d6dd647
Make plan_management_iframe_uri be a String not URL
hughns 4863920
Lint
hughns 037d90b
Update schemas
hughns 264988f
Revert unnecessary change
hughns 9460f5d
GraphQL model docstring
hughns b10607e
Lint
hughns 55f559e
Schema update
hughns File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not convinced that this has to be a URL? Like if we want to have a relative link here, it won't get accepted?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose someone might want to configure it with a relative URL.
Are you thinking that it is just a string that is passed through without validation? Or are you thinking the value is parsed from config relative to
http.public_base
and then the site config still return a full URL? Or something else entirely?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm indeed thinking of just passing it as as string without validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've converted into a
String
with some additional doc comments in d6dd647