Support suggesting email as login_hint
#4568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatMaul
reviewed
May 15, 2025
mcalinghee
force-pushed
the
feat/login_hint_with_email
branch
from
86e806c to
34762a6
Compare
mcalinghee
force-pushed
the
feat/login_hint_with_email
branch
from
34762a6 to
9c9cc3d
Compare
sandhose
requested changes
Jun 3, 2025
mcalinghee
force-pushed
the
feat/login_hint_with_email
branch
3 times, most recently
from
0a1c9a2 to
52bb16b
Compare
mcalinghee
force-pushed
the
feat/login_hint_with_email
branch
from
52bb16b to
07ac7ca
Compare
mcalinghee
force-pushed
the
feat/login_hint_with_email
branch
7 times, most recently
from
2e23003 to
28a15d4
Compare
mcalinghee
force-pushed
the
feat/login_hint_with_email
branch
from
28a15d4 to
d18fcaa
Compare
odelcroi
force-pushed
the
feat/login_hint_with_email
branch
from
d18fcaa to
a5d3a2f
Compare
4 tasks
mcalinghee
changed the title
login_hint to upstream providers
mcalinghee
changed the title
login_hint to upstream providerslogin_hint
sandhose
requested changes
Jul 30, 2025
mcalinghee
force-pushed
the
feat/login_hint_with_email
branch
from
9b1c45f to
cdf53ca
Compare
Member
|
@mcalinghee after an initial review, I would appreciate if you don't force-push to the branch, as it often makes GitHub confused and makes it harder to understand what changed. If you ever need to update from the main branch, prefer merging it into your branch instead of rebasing :) |
…correct documentation
sandhose
approved these changes
Aug 18, 2025
Member
sandhose
left a comment
sandhose
left a comment
There was a problem hiding this comment.
Thanks for this! I've pushed a few cosmetic fixes myself, but this looks good to me now!
sandhose
changed the title
login_hintlogin_hint
sandhose
added
A-Login-Flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to forward the login_hint with a mxid to the upstream providers thanks to #4512
This PR allows us to support the
login_hintwith an email whenlogin_with_email_allowedis activated.In particular this PR will display the login_hint ie. email on the MAS login page.
It will also forward the email
login_hintto upstream providers.