Skip to content

Miscellaneous housekeeping #4735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 16, 2025
Merged

Miscellaneous housekeeping #4735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c42a33f
Fix .gitignore for cargo target directory.
jevolk Jun 29, 2025
e8b5481
Replace std::io::Error::new with Error::other.
jevolk Jun 29, 2025
c11d82c
rand::OsRng is no longer reachable.
jevolk Jun 29, 2025
925a41e
Fix rogue invalid characters inside doc comments.
jevolk Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Please see LICENSE files in the repository root for full details.

# Rust
target/
target

# Editors
.idea
Expand Down
1 change: 0 additions & 1 deletion clippy.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ disallowed-methods = [
]

disallowed-types = [
"rand::OsRng",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was mainly for avoiding people creating RNGs on the fly instead of passing them down by parameters, but yeah I'm fine with removing that from this list!

{ path = "std::path::PathBuf", reason = "use camino::Utf8PathBuf instead" },
{ path = "std::path::Path", reason = "use camino::Utf8Path instead" },
]
3 changes: 1 addition & 2 deletions crates/handlers/src/graphql/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,8 +341,7 @@ pub async fn post(

let request = async_graphql::http::receive_body(
content_type,
body.map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, e))
.into_async_read(),
body.map_err(std::io::Error::other).into_async_read(),
MultipartOptions::default(),
)
.await?
Expand Down
2 changes: 1 addition & 1 deletion crates/storage/src/compat/access_token.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use ulid::Ulid;
use crate::{Clock, repository_impl};

/// A [`CompatAccessTokenRepository`] helps interacting with
/// [`CompatAccessToken`] saved in the storage backend
/// [`CompatAccessToken`] saved in the storage backend
#[async_trait]
pub trait CompatAccessTokenRepository: Send + Sync {
/// The error type returned by the repository
Expand Down
2 changes: 1 addition & 1 deletion crates/storage/src/oauth2/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ use url::Url;

use crate::{Clock, repository_impl};

/// An [`OAuth2ClientRepository`] helps interacting with [`Client`] saved in the
/// An [`OAuth2ClientRepository`] helps interacting with [`Client`] saved in the
/// storage backend
#[async_trait]
pub trait OAuth2ClientRepository: Send + Sync {
Expand Down
Loading