Make back-channel logout work on existing sessions #4767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on_sessions table
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the id_token_claims column on upstream_oauth_authorization_sessions is populated both retrospectively and going forward by decoding the JWT payload in id_token.
- Introduces a PL/pgSQL function (
fill_id_token_claims) and trigger (trg_fill_id_token_claims) to auto-fill claims on INSERT/UPDATE when missing. - Runs an
UPDATEto backfillid_token_claimsfor existing sessions.
Comments suppressed due to low confidence (1)
crates/storage-pg/migrations/20250709142230_backfill_id_token_claims.sql:53
- [nitpick] Consider adding automated tests (or a test harness) for this migration and trigger to verify that
id_token_claimsis correctly backfilled and populated on new/updated rows.
UPDATE upstream_oauth_authorization_sessions
crates/storage-pg/migrations/20250709142230_backfill_id_token_claims.sql
Show resolved
Hide resolved
crates/storage-pg/migrations/20250709142230_backfill_id_token_claims.sql
Show resolved
Hide resolved
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
620f214
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://765cacc5.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-backfill-id-token-c.matrix-authentication-service-docs.pages.dev |
Co-authored-by: Copilot <[email protected]>
reivilibre
approved these changes
Jul 10, 2025
sandhose
added
the
T-Task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backfills the id_token_claims column in the upstream_oauth_authorization_sessions table by decoding the id_token in each row.
Because we're worried about rolling updates and rollbacks, it also adds a trigger that fills the id_token_claims column on the fly if it's not set. We should be able to drop this trigger in a later version of MAS.