Show a better error page in most human-facing pages #4816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
0b583b6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://daf923bf.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-sensible-error-page.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/sensible-error-pages
branch
from
489aced to
0b583b6
Compare
reivilibre
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so that most human-facing pages will render a GenericError/InternalError which then gets a nicer rendering in the browser.
It's not perfect, but at least this page will loop through the error sources and display more details, which is helpful for debugging things like issues with upstream OAuth providers.