Use the stable MAS integration of Synapse in the documentation and in mas-cli doctor
#4902
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the documentation and mas-cli doctor command to use the stable Matrix Authentication Service (MAS) integration with Synapse, replacing references to the experimental MSC3861 feature.
- Updates Synapse configuration from
experimental_features.msc3861tomatrix_authentication_service - Simplifies the MAS integration by removing the need for explicit client provisioning
- Updates the doctor command to check the new MAS API endpoints and configuration format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/setup/homeserver.md | Updates documentation to use stable matrix_authentication_service configuration, removes client provisioning section, and adds migration guide |
| crates/cli/src/commands/doctor.rs | Updates doctor command to check new MAS API endpoints and reference stable configuration format in error messages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
0a5f05f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a707cf88.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-stable-docs.matrix-authentication-service-docs.pages.dev |
| // Try to reach the admin API on an unauthorized endpoint | ||
| let server_version = hs_api.join("/_synapse/admin/v1/server_version")?; | ||
| let result = http_client.get(server_version.as_str()).send_traced().await; | ||
| match result { | ||
| Ok(response) => { | ||
| let status = response.status(); | ||
| if status.is_success() { | ||
| info!(r#"✅ The Synapse admin API is reachable at "{server_version}"."#); | ||
| } else { | ||
| error!( | ||
| r#"❌ A Synapse admin API endpoint at "{server_version}" replied with {status}. | ||
| Make sure MAS can reach the admin API, and that the homeserver is running. | ||
| "# | ||
| ); | ||
| } | ||
| } | ||
| Err(e) => error!( | ||
| r#"❌ Can't reach the Synapse admin API at "{server_version}". | ||
| Make sure MAS can reach the admin API, and that the homeserver is running. | ||
There was a problem hiding this comment.
Why is this no longer useful? Doesn't MAS still need to use Synapse's Admin API in several cases?
There was a problem hiding this comment.
It's using a dedicated API now, and doesn't have full admin access anymore
There was a problem hiding this comment.
This is also now just testing for the dedicated MAS API, which should cover both the 'it's unreachable' and the 'it's the wrong secret' cases
mas-cli doctorto suggest the stable MAS integration