Skip to content

Conversation

LeonWilzer
Copy link
Contributor

token_endpoint_auth_signing_alg_values_supported is an optional value according to OIDC spec

token_endpoint_auth_signing_alg_values_supported is an optional value
according to OIDC spec
@CLAassistant
Copy link

CLAassistant commented Sep 5, 2025

CLA assistant check
All committers have signed the CLA.

@LeonWilzer
Copy link
Contributor Author

According to the OIDC spec token_endpoint_auth_signing_alg_values_supported is optional, but MAS demands the field in secure discovery mode, even if MAS isn't configured to use JWT. We are running into issues because of this.

Copy link
Member

@sandhose sandhose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem is that I took the RFC8414 definition for this one:

token_endpoint_auth_signing_alg_values_supported
      OPTIONAL.  JSON array containing a list of the JWS signing
      algorithms ("alg" values) supported by the token endpoint for the
      signature on the [JWT](https://www.rfc-editor.org/rfc/rfc8414.html#ref-JWT) [JWT] used to authenticate the client at the
      token endpoint for the "private_key_jwt" and "client_secret_jwt"
      authentication methods.  This metadata entry MUST be present if
      either of these authentication methods are specified in the
      "token_endpoint_auth_methods_supported" entry.  No default
      algorithms are implied if this entry is omitted.  Servers SHOULD
      support "RS256".  The value "none" MUST NOT be used.

Thanks for this! I think I need to do a round and be less strict with many of those fields

@sandhose sandhose changed the title make token_endpoint_auth_signing_alg_values_supported optional Make token_endpoint_auth_signing_alg_values_supported optional in upstream OIDC providers Sep 12, 2025
@sandhose sandhose changed the title Make token_endpoint_auth_signing_alg_values_supported optional in upstream OIDC providers Make token_endpoint_auth_signing_alg_values_supported optional in upstream OIDC providers metadata Sep 12, 2025
@sandhose sandhose added A-Upstream-OAuth Related to login via upstream OAuth 2.0 providers T-Defect Something isn't working labels Sep 12, 2025
@sandhose sandhose merged commit b71a770 into element-hq:main Sep 12, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Upstream-OAuth Related to login via upstream OAuth 2.0 providers T-Defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants