Admin API filter to search users by username

[sandhose]

No description provided.

[cloudflare-workers-and-pages]

Deploying matrix-authentication-service-docs with    Cloudflare Pages

Latest commit:	a7e56b3
Status:	✅  Deploy successful!
Preview URL:	https://5a0b290c.matrix-authentication-service-docs.pages.dev
Branch Preview URL:	https://quenting-admin-api-user-sear.matrix-authentication-service-docs.pages.dev

View logs

[sandhose]

The only tricky thing is that before PG 16 you have to be superuser to execute that. Which is probably fine in most Docker environments for example?

[reivilibre]

hmm yikes. Feels like something we should at least call out somewhere, v15 still has another 2 years on it and I'm not sure people will know how to run this manually as a superuser.

[reivilibre]

two things to do:

• add documentation to the database page and upgrade notes for this migration, for Pg <= 15;
• check that if the superuser on Pg 15 already created the extension, whether a non-superuser is then able to complete the migration as a no-op?

[sandhose]

I will add things in the docs. We don't have upgrade notes, so it will have to be manual in the release notes somehow. I did check for CREATE EXTENSION IF NOT EXISTS with PG 13 and it works:

sandhose=# CREATE ROLE unprivileged;
CREATE ROLE
sandhose=# SET ROLE unprivileged ;
SET
sandhose=> CREATE EXTENSION IF NOT EXISTS pg_trgm;
ERROR:  permission denied to create extension "pg_trgm"
HINT:  Must have CREATE privilege on current database to create this extension.
sandhose=> SET ROLE sandhose ;
SET
sandhose=# CREATE EXTENSION IF NOT EXISTS pg_trgm;
CREATE EXTENSION
sandhose=# SET ROLE unprivileged ;
SET
sandhose=> CREATE EXTENSION IF NOT EXISTS pg_trgm;
NOTICE:  extension "pg_trgm" already exists, skipping
CREATE EXTENSION

[sandhose]

@reivilibre I've added things in the documentation in a3ecdc9 and put what should be added to the release notes in the PR body, wdyt?

[reivilibre]

release notes mostly OK, would just say that maybe it needs a more obvious 'If you are using Postgres 15 or earlier and MAS doesn't run as a Postgres superuser, run ... as a superuser prior to updating MAS.'

Might just be me but I feel it's easy to miss the fact I might need to do something, in the current text.

[sandhose]

After double-checking, turns out trusted extensions were a thing introduced in PG 13, which is the version we ask for anyway. So I reverted the docs change