Always initialize OpenTelemetry even if no exporter is configured #5128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
f0ac252
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://04866eaf.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-always-init-otel.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/always-init-otel
branch
from
7620b3e to
f0ac252
Compare
reivilibre
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5124
This always initialises the OTEL tracing layer. This has the advantage of getting context propagation through MAS to work even though we don't export the traces.
In theory this would also mean that we always get a trace ID, but that would add it to the logs all the time. So I tweaked the
IdGeneratorto return an invalid trace in case we have no exporter, which means: