-
Notifications
You must be signed in to change notification settings - Fork 68
Personal Sessions: add create, list, get, revoke, regenerate Admin APIs #5141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f35dcf8 to
8bc8857
Compare
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
dda3a49
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b755e684.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://rei-pat-admin.matrix-authentication-service-docs.pages.dev |
8bc8857 to
3260f51
Compare
5e5911c to
6dec565
Compare
11f9074 to
9ba5df4
Compare
9ba5df4 to
129b7f3
Compare
129b7f3 to
4863026
Compare
| .await?; | ||
| } | ||
|
|
||
| // Delete any personal access tokens & sessions owned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat.
crates/handlers/src/admin/model.rs
Outdated
| revoked_at: Option<DateTime<Utc>>, | ||
|
|
||
| /// The ID of the user who owns this session (if user-owned) | ||
| #[schemars(with = "super::schema::Ulid")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be #[schemars(with = "Option<super::schema::Ulid>")] I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm hm, I think I got this from CompatSession, which also doesn't have the Option in the with type. Any idea if this is on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
→ 6102a4b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea if this is on purpose?
definitely not on purpose
…ame as last time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, take your tick and run!
Follows: #5106
Part of: #4492
This PR introduces some admin API endpoints for Personal Sessions.