Support personal access tokens for introspection #5171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
66f8814
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://97fc8df0.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://rei-pat-2.matrix-authentication-service-docs.pages.dev |
sandhose
approved these changes
Oct 20, 2025
| &self, | ||
| clock: &dyn Clock, | ||
| session: &Session, | ||
| session: &PersonalSession, |
Comment on lines
+690
to
+695
| PersonalSessionOwner::OAuth2Client(owner_client_id) => { | ||
| let owner_client = repo | ||
| .oauth2_client() | ||
| .lookup(owner_client_id) | ||
| .await? | ||
| .ok_or(RouteError::CantLoadOAuth2Client(owner_client_id))?; |
There was a problem hiding this comment.
I mean in theory we have a FK preventing this but sure, doesn't hurt :)
There was a problem hiding this comment.
indeed, though we do this already for some things, it felt easier to go with the flow somewhat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows: #5106
Part of: #4492
This PR makes it so that you can present a personal access token (
mpt_prefix) at introspection and have it accepted.This means personal access tokens can be presented to Synapse and used on the client-server API.