Fix spurious "Failed to set parent context on span" error #5228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would happen when the `info` log level is surpressed, and therefore the request span would not be enabled and fail to set the parent OTEL context.
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
eeb5d61
|
| Status: | 🚫 Build failed. |
reivilibre
approved these changes
Nov 7, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a guard to prevent setting parent context on disabled tracing spans, which previously caused errors when certain log levels were configured (e.g., RUST_LOG=warn).
Key Changes:
- Added
is_disabled()check before extracting and setting parent span context - Added explanatory comment about why this guard is necessary
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would happen when the
infolog level is suppressed (e.g.RUST_LOG=warn), and therefore the request span would not be enabled and fail to set the parent OTEL context.I've put the fix against the release branch to avoid having to wait for another release cycle if that's alright