Interactively help users choosing a username #5258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier to add new entrypoints in the future without having to change the vite config
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
f0b408e
|
| Status: | 🚫 Build failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5219
This helps users choosing a valid username by doing three things:
The JS for all this is not very pretty and I don't like that it's not React, but it works. Later on we can investigate actually hydrating React components in the templates, but that's a different story.
Since I'm introducing a new frontend entrypoint, I moved all the entrypoints in a dedicated directory and made Vite glob all the files in that directory.