-
Notifications
You must be signed in to change notification settings - Fork 68
Add Shibboleth sample configuration to SSO documentation #5294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: sandhose <[email protected]>
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
b2fb289
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://22d45852.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://copilot-add-sample-shibbolet.matrix-authentication-service-docs.pages.dev |
|
@copilot I don't think you need the userinfo_endpoint, it's probably set correctly in the well-known |
Co-authored-by: sandhose <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive documentation for configuring Shibboleth as an SSO upstream provider for the Matrix Authentication Service. Shibboleth is a widely-used open-source identity management system in universities and research institutions, making this a valuable addition for that user base.
Key Changes
- Added complete Shibboleth SSO configuration example following the established documentation pattern
- Included instructions for registering MAS as a relying party in Shibboleth
- Provided YAML configuration with proper OIDC claims mapping
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot I actually wanted a review not an overview. Can you especially check that all the config options are genuine config options and make sense for the task at hand? |
|
@copilot I notice |
I've verified all config options against the configuration reference at
All options are genuine and appropriate for Shibboleth OIDC configurations. |
Co-authored-by: sandhose <[email protected]>
|
@copilot here's an excerpt of the docs for the OIDC plugin: OverviewThis is a profile defining the expression of OIDC and OAuth client capabilities and characteristics in SAML 2.0 Metadata, which is the native and preferred metadata format supported by the Shibboleth IdP software. An example representing an OIDC RP with client secret value in the metadata: <md:EntityDescriptor
xmlns:md="urn:oasis:names:tc:SAML:2.0:metadata"
xmlns:oidcmd="urn:mace:shibboleth:metadata:oidc:1.0"
entityID="mockSamlClientId">
<md:SPSSODescriptor protocolSupportEnumeration="http://openid.net/specs/openid-connect-core-1_0.html">
<md:Extensions>
<oidcmd:OAuthRPExtensions
grant_types="authorization_code"
response_types="code"
token_endpoint_auth_method="client_secret_basic"
scopes="openid profile" />
</md:Extensions>
<md:KeyDescriptor>
<ds:KeyInfo xmlns:ds="http://www.w3.org/2000/09/xmldsig#">
<oidcmd:ClientSecret>mockClientSecretValue</oidcmd:ClientSecret>
</ds:KeyInfo>
</md:KeyDescriptor>
<md:NameIDFormat>urn:mace:shibboleth:metadata:oidc:1.0:nameid-format:public</md:NameIDFormat>
<md:AssertionConsumerService
Binding="https://tools.ietf.org/html/rfc6749#section-3.1.2"
Location="https://example.org/cb"
index="1"/>
</md:SPSSODescriptor>
</md:EntityDescriptor>Could you reword your instructions to use that information? |
|
@copilot I meant please give in the docs a full example with a whole metadata file instead of asking users to figure that themselves out |
Co-authored-by: sandhose <[email protected]>
Added a complete Shibboleth metadata file example in b2fb289. The example includes all necessary elements: EntityDescriptor with OIDC extensions, client secret, scopes, token endpoint auth method, grant types, response types, and the redirect URI. |
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.